-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: add ability to create Partitioned Cookies #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COuld you add a test?
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
Co-authored-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com>
Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
@Eomm , Tests added |
Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
@Uzlopak Thanks ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title needs to be rewritten as it's not great in its current state. Won't make much sense to users reading release notes.
What is wrong with this CI? Rerunning |
PTAL |
It's not enabled by default? Also, I wonder why we're not using fastify/cookie's cookie module here |
And we might want to label it as experimental or non-standard |
Co-authored-by: Gürgün Dayıoğlu <gurgun.dayioglu@icloud.com>
I am completely against making a draft proposal the default implementation of anything. |
Yeah me too, the title is wrong, the PR just adds |
Is the title now better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you everyone ! |
Related to #213
run
npm run test
andnpm run benchmark
npm run benchmark -> failed
TypeError: redisStoreFactory is not a function
at createServer (C:\GitHub\fastify-session\benchmark\bench.js:19:24)
at testFunction (C:\GitHub\fastify-session\benchmark\bench.js:56:18)
at main (C:\GitHub\fastify-session\benchmark\bench.js:83:15)
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct