update to latest fastify and all plugin to latest release; configure… #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tap tests to run in parallel; fix lint errors
… release used (anyway not 0.x anymore)
delvedor
reviewed
Nov 16, 2018
test.js
Outdated
|
|
||
| // Increased to prevent Travis to fail | ||
| process.nextTick(() => sleep(1000)) | ||
| sget({ | ||
| method: 'GET', | ||
| url: 'http://localhost:' + fastify.server.address().port | ||
| url: `${address}` |
There was a problem hiding this comment.
You can use just address, there is no need to use a template string :)
There was a problem hiding this comment.
@delvedor removed template strings where not really needed ... thanks for the feedback
cemremengu
suggested changes
Nov 19, 2018
|
@cemremengu Hi, should I do even the change in the README, or do you prefer to do it (other than the new plugin release number) ? |
|
@smartiniOnGitHub you can do it in this PR I think. It will be just a single line in readme |
cemremengu
approved these changes
Nov 19, 2018
|
@cemremengu updated README, hope it's good enough. Bye |
|
Hi all, sorry but this is still to merge ... |
|
@smartiniOnGitHub merge+publish done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… tap tests to run in parallel; fix lint errors (from the updated version of the linter).
Note that I didn't change the release of the plugin, it need ot be done after.
Last the v0.2.0 tag is missing.
Bye,
Sandro