Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flakyness of tests #181

Merged
merged 1 commit into from
Aug 2, 2022
Merged

fix flakyness of tests #181

merged 1 commit into from
Aug 2, 2022

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 2, 2022 •
edited
Loading

Checklist

@Uzlopak Uzlopak requested review from mcollina and Fdawgs August 2, 2022 09:56
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 2, 2022 •
edited
Loading

@Fdawgs

I hope this fixes the flakyness, you mentioned in #179

mcollina
mcollina approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, amazing work!

@Uzlopak Uzlopak merged commit e3a1963 into master Aug 2, 2022
@Uzlopak Uzlopak deleted the fix-flaky-tests branch August 2, 2022 11:38
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 2, 2022

I guess, it is not totally fixed, but less flaky. I guess to fix it permanently we have to increase the timings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Fdawgs Fdawgs Fdawgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uzlopak @mcollina @Fdawgs