Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps-dev): replace standard with neostandard #242

Merged
merged 3 commits into from
Dec 8, 2024
Merged

build(deps-dev): replace standard with neostandard #242

merged 3 commits into from
Dec 8, 2024

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Dec 8, 2024

See fastify/fastify-cors#340. This is a batch PR, so may have some issues. Please review changes.

@Fdawgs Fdawgs changed the title chore: add eslint.config.js build(deps-dev): replace standard with neostandard Dec 8, 2024
gurgunday
gurgunday reviewed Dec 8, 2024
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the failing ones require a npm run lint:fix?

@Fdawgs
Copy link
Member Author

Fdawgs commented Dec 8, 2024 •
edited
Loading

I suppose the failing ones require a npm run lint:fix?

They've all had a lint:fix ran over them. If they have linting errors then it's things that neostandard couldn't fix automatically.

@Uzlopak Uzlopak merged commit ff839b0 into master Dec 8, 2024
13 checks passed
@Uzlopak Uzlopak deleted the build/standard branch December 8, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fdawgs @gurgunday @Uzlopak