Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kafka workflow #113

Merged
merged 2 commits into from
Apr 22, 2024
Merged

add kafka workflow #113

merged 2 commits into from
Apr 22, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Dec 25, 2023

Checklist

mcollina
mcollina previously approved these changes Dec 26, 2023
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

Why are we adding this here even if it's just for a single plugin?

gurgunday
gurgunday previously approved these changes Dec 26, 2023
@gurgunday
Copy link
Member

I feel like this is a good place to centralize service-related workflows

For instance, if I ever need to look for a specific workflow (like kafka), I might forget which plugin uses it and just check here

Fdawgs
Fdawgs previously approved these changes Jan 24, 2024
@Uzlopak Uzlopak closed this Mar 21, 2024
@gurgunday gurgunday mentioned this pull request Apr 20, 2024
4 tasks
@gurgunday gurgunday reopened this Apr 21, 2024
@gurgunday gurgunday dismissed stale reviews from Fdawgs, mcollina, and themself via 77551b9 April 21, 2024 09:24
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday merged commit 821ceac into main Apr 22, 2024
1 check passed
@gurgunday gurgunday deleted the kafka-workflow branch April 22, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants