Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make node versions dynamic #124

Merged
merged 12 commits into from
Apr 23, 2024
Merged

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Apr 19, 2024

This will let us use the centralized workflow for most libraries

Examples of where it will be used if merged:

fastify/proxy-addr#61 (review)
fastify/fluent-json-schema#242
fastify/process-warning#104

and other @fastify/libraries repos

@gurgunday gurgunday requested review from Eomm and Fdawgs April 19, 2024 19:47
@gurgunday gurgunday mentioned this pull request Apr 20, 2024
4 tasks
.github/workflows/plugins-ci-postgres.yml Outdated Show resolved Hide resolved
@gurgunday
Copy link
Member Author

Should package managers be tested cross platform?

@Fdawgs
Copy link
Member

Fdawgs commented Apr 22, 2024

Should package managers be tested cross platform?

Probably leave those on Ubuntu only as well, so they match what the main Fastify repo is doing. :)

If you could update the readme with the new option as well then this PR'll be good to go!

@gurgunday
Copy link
Member Author

Done, let me know if the README could be improved

Fdawgs
Fdawgs previously approved these changes Apr 22, 2024
@gurgunday
Copy link
Member Author

Just reverted an unnecessary change to benchmark

815aca9

@gurgunday gurgunday merged commit 05d3c0b into fastify:main Apr 23, 2024
1 check passed
@gurgunday gurgunday deleted the dynamic-node-versions branch April 23, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants