-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to use Individual API key in deliver and pilot #22128
Add ability to use Individual API key in deliver and pilot #22128
Conversation
b04f6d1
to
7fb05db
Compare
bc0e245
to
42b16e2
Compare
If I understand this correctly, when running the pilot command (with distribute_external set), this will:
Did I get it somewhat correctly? :) |
@neorth |
Just tested this successfully using the pilot command. 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this enhancement. ❤️
Looks good to me 💯
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #22115
Description
altool
used internally bydeliver
andpilot
has not support Individual API Keys yet.With this change, fastlane determines the type of API key when uploading a build, and if the API key is a Team API Key, it will use the API key as is, but if it is an Individual API Key, it will not use the key and will use the the application specific password.
Testing Steps
Prerequisites
FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD
INDIVIDUAL_API_KEY_ID
INDIVIDUAL_API_KEY_CONTENT_BASE64
FASTLANE_USER
(necessary if it is not specified in your AppFile)Release
configurationSteps
I successfully uploaded my app to TestFlight and AppStore Connect with this branch's fastlane.