Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 prepare release 0.5.0 #261

Merged
merged 2 commits into from
May 16, 2023
Merged

🎁 prepare release 0.5.0 #261

merged 2 commits into from
May 16, 2023

Conversation

JakeChampion
Copy link
Contributor

Cutting a new release, this currently contains steps 1 through to 5 of Releasing Viceroy.

  1. Make sure the Viceroy version has been bumped up to the current release
    version. You might need to bump the minor version (e.g. 0.2.0 to 0.3.0) if
    there are any semver breaking changes. Review the changes since the last
    release just to be sure.
  2. Update the Cargo.lock files by running make generate-lockfile.
  3. Update CHANGELOG.md so that it contains all of the updates since the
    previous version as its own commit.
  4. Create a local branch in the form release-x.y.z where x, y, and z are
    the major, minor, and patch versions of Viceroy and have the tip of the
    branch contain the Changelog commit.
  5. Run make ci locally to make sure that everything will pass before pushing
    the branch and opening up a PR.

Copy link
Contributor

@acfoltzer acfoltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah, I just noticed that there's a semver break with the new HandleError::InvalidPendingKvLookupHandle variant. We need to mark that #[non_exhaustive] if it's gonna be publicly exposed (this probably applies to some other types as well).

For now, would you mind changing the crate versions to 0.5.0 before we release?

@acfoltzer
Copy link
Contributor

acfoltzer commented May 11, 2023

Oh, the changes to insert_pending_request are also part of the public interface to viceroy-lib, which causes breakage as well. I think we're probably exposing more than we need to from this crate and laying semver traps for ourselves. I'll make a follow-up issue for us to examine that and hopefully cut a 0.6.0 that makes future changes less disruptive.

@JakeChampion JakeChampion changed the title 🎁 prepare release 0.4.6 🎁 prepare release 0.5.0 May 12, 2023
acfoltzer
acfoltzer previously approved these changes May 12, 2023
Copy link
Contributor

@acfoltzer acfoltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Approved to advance to step 6 🚀

Copy link
Contributor

@acfoltzer acfoltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay on this, thanks for closing the loop ➰

@JakeChampion JakeChampion merged commit db74016 into main May 16, 2023
@JakeChampion JakeChampion deleted the release-0.4.6 branch May 16, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants