draft: generate certificate and serve over http and https #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
force-pushed
the
jake/https
branch
5 times, most recently
from
eca7734
to
884e3c7
Compare
|
I have a high expectation of this! |
|
This seems really promising! In addition to the TODOs above, have you considered allowing the user to provide a list of SAN(s) to be included in the cert, so that they can test with their 'real' name for the service? |
kpfleming
reviewed
Jul 29, 2024
lib/src/service.rs
Outdated
| .await | ||
| .unwrap(); | ||
|
|
||
| let addr = SocketAddr::new(IpAddr::V4(std::net::Ipv4Addr::new(127, 0, 0, 1)), 7879); |
There was a problem hiding this comment.
Is there a benefit to this more-verbose construct, compared to the simpler one on line 78?
JakeChampion
force-pushed
the
jake/https
branch
from
20df4d8
to
7f6f907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pushing this up to see if there is interest in seeing this feature land and if this approach is along the right tracks
TODO: