Enable custom profiling interval via CLI flag (#357) #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add match case for when interval is None, and when one exists
also update `profile_guest()`, ignore interval in that function
Pass `None` for profiling interval in tests
ExecuteCtx::new takes an additional argument now, namely the profiling interval.
- Should be allowed to pass interval as `100ms` or `100` and default to milliseconds
|
Hi @katef, I moved this from draft to 'ready for review'. Please let me know if this looks alright! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #357 (guest profiler support originally added in #301)
This PR adds the ability to pass a profiling interval to Viceroy, e.g.
--profile=guest,/tmp/path,25will set the profiling sample interval to 25 ms.Open question(s):
It looks likewasmtimewill parse the time including units, e.g.--profile=guest,/some/path,25ms. This PR assumes milliseconds by default. I can either add a smallparse_durationhelper function or use thehumantimecrate (used bywasmtime, so already an implicit project dependency) to stay consistent withwasmtime. Thoughts?EDIT: I've added support for
humantime, but if this is not preferable I'm happy to revert the latest change.0.05ms (50 microseconds). The default interval inwasmtimeappears to be10ms. Should Viceroy's default be changed?