Update Fastly crate from 0.10.4 to 0.11.1
#445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the test fixtures to use the newly released `0.11.1` Fastly crate. When `fastly::acl` hostcalls were added in #438, the corresponding SDK support was not yet released. So #438 added tests using the still-unreleased-SDK, but put that code behind a compile-time gate ([here](#438 (comment))). This change removes that compile-time gate in `test-fixtures/src/bin/acl.rs`, effectively changing these tests from a no-op to running the desired test cases. A few other text-fixtures stopped compiling with the updated SDK, which I've tried to address: - `test-fixtures/src/bin/inspect.rs` cc/ @ulyssa - `test-fixtures/src/bin/kv_store.rs` cc/ @joeshaw
computermouth
previously approved these changes
Dec 5, 2024
ulyssa
previously approved these changes
Dec 5, 2024
|
It looks like the tests are failing because there isn't support for the |
ulyssa
approved these changes
Dec 5, 2024
|
It looks like the macos-12 image is now completely unsupported (actions/runner-images#10721), so I've removed it from the required checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the test fixtures to use the newly released
0.11.1Fastly crate.When
fastly::aclhostcalls were added in #438, the corresponding SDK support was not yet released. So #438 added tests using the still-unreleased-SDK, but put that code behind a compile-time gate (here).This change removes that compile-time gate in
test-fixtures/src/bin/acl.rs, effectively changing these tests from a no-op to actually running the desired test cases.A few other text-fixtures stopped compiling with the updated SDK, which I've tried to address as well:
test-fixtures/src/bin/inspect.rscc/ @ulyssatest-fixtures/src/bin/kv_store.rscc/ @joeshawThe following hostcalls were missing from the component/adapter, and so were added:
fastly_http_req#send_v3fastly_http_req#send_async_v2fastly_http_cache(entire module)