Skip to content

Commit

Permalink
More test fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
grantstephens committed Nov 15, 2022
1 parent eeee580 commit 03943db
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion pkg/commands/backend/backend_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ func TestBackendCreate(t *testing.T) {
},
// The following test is the same as above but mocks a successful backend
// creation so we can validate the correct service version was utilised.

// NOTE: Added --port flag to validate that a nil pointer dereference is
// not triggered at runtime when parsing the arguments.
{
Expand Down
4 changes: 0 additions & 4 deletions pkg/commands/backend/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,13 +160,9 @@ func (c *CreateCommand) Exec(_ io.Reader, out io.Writer) error {
if c.overrideHost.WasSet {
input.OverrideHost = fastly.String(c.overrideHost.Value)
}

if c.requestCondition.WasSet {
input.RequestCondition = fastly.String(c.requestCondition.Value)
}
if c.serviceName.WasSet {
input.Name = fastly.String(c.serviceName.Value)
}
if c.shield.WasSet {
input.Shield = fastly.String(c.shield.Value)
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/commands/vcl/custom/custom_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func TestVCLCustomCreate(t *testing.T) {
return &fastly.VCL{
Content: *i.Content,
Main: *i.Main,
Name: *i.Name,
Name: fastly.String(i.Name),
ServiceID: i.ServiceID,
ServiceVersion: i.ServiceVersion,
}, nil
Expand Down

0 comments on commit 03943db

Please sign in to comment.