Skip to content

Commit

Permalink
logging: add comment to heroku create
Browse files Browse the repository at this point in the history
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
  • Loading branch information
mccurdyc authored and pteichman committed May 18, 2020
1 parent dd33247 commit 2837972
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions pkg/logging/heroku/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ type CreateCommand struct {
func NewCreateCommand(parent common.Registerer, globals *config.Data) *CreateCommand {
var c CreateCommand

// Without this, parsing flags leads to panics.
// This is because if we try to scan directly into c.Input.<Field> without first
// creating a valid reference, flags will attempt to be scanned into null pointers.
// This will result in sending the zero value values for unset flags which is acceptable
// for Creates, but not Updates.
c.Input = fastly.CreateHerokuInput{
Name: fastly.String(""),
Format: fastly.String(""),
Expand Down

0 comments on commit 2837972

Please sign in to comment.