Skip to content

Commit

Permalink
fix(compute/serve): don't fail the serve workflow if github errors
Browse files Browse the repository at this point in the history
  • Loading branch information
Integralist committed Jul 11, 2024
1 parent c2f28dc commit 61f2cf6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/commands/compute/serve.go
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,8 @@ func (c *ServeCommand) InstallViceroy(
// IMPORTANT: We declare separately so to shadow `err` from parent scope.
var latestVersion string

// NOTE: We won't stop the user because although we can't request the latest
// version of the tool, the user may have a local version already installed.
err = spinner.Process("Checking latest Viceroy release", func(_ *text.SpinnerWrapper) error {
latestVersion, err = c.ViceroyVersioner.LatestVersion()
if err != nil {
Expand All @@ -487,7 +489,7 @@ func (c *ServeCommand) InstallViceroy(
return nil
})
if err != nil {
return err
return nil // short-circuit the rest of this function
}

viceroyConfig := c.Globals.Config.Viceroy
Expand Down

0 comments on commit 61f2cf6

Please sign in to comment.