Filter unwanted files from template repository whilst initialising #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbourgon
approved these changes
Feb 12, 2020
| @@ -3,16 +3,16 @@ fastly | |||
|
|
|||
| # Fastly package format files | |||
| **/fastly.toml | |||
| !pkg/packag/testdata/build/fastly.toml | |||
| }{ | ||
| // TODO(pb): wait until package template repo is public |
There was a problem hiding this comment.
I'm slightly confused, the repo is now public, hence why I've written these tests?
There was a problem hiding this comment.
I know, I was just having a little laugh, please ignore :)
| name = "edge-compute-default-rust-template" | ||
| version = "0.1.0" | ||
| authors = ["phamann <patrick@fastly.com>"] | ||
| edition = "2018" |
There was a problem hiding this comment.
This is the correct edition. See here for more info: https://doc.rust-lang.org/edition-guide/editions/index.html
There was a problem hiding this comment.
Oh, it's the Rust edition, I see 👍
Co-Authored-By: Peter Bourgon <peterbourgon@users.noreply.github.com>
Co-Authored-By: Peter Bourgon <peterbourgon@users.noreply.github.com>
Co-Authored-By: Peter Bourgon <peterbourgon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
A by-product of open sourcing the default template that we clone during
compute initis we now also copy certain extraneous files that don't make sense being in a newly created project, such as theLICENSE,SECURITY.mdand.githubworkflow directory. This PR attempts to solve this my creating a list of files we filter out during the copying process. It also adds tests forcompute initwhich we were waiting for the repository to be public before writing.