add tinygo starter kit #1011
Merged
add tinygo starter kit #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgryski
reviewed
Sep 14, 2023
Integralist
reviewed
Sep 15, 2023
There was a problem hiding this comment.
I think you're going to need to also bump the config_version inside of the .fastly/config.toml (which is merged with the output of this script to produce the final config.toml that's embedded into the CLI -- https://github.com/fastly/cli/blob/main/DEVELOP.md#fastlyconfigtoml).
If we don't bump the version, then the CLI will just end up using the config file already on the user's machine.
Where as bumping the version causes this line to get executed when the user invokes a CLI command (as the config has to be loaded when using the CLI): https://github.com/fastly/cli/blob/main/pkg/config/config.go#L325-L335.
Integralist
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.