Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compute/deploy): avoid store conflicts #1041

Merged
merged 23 commits into from
Oct 17, 2023

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Oct 11, 2023

Fixes #770 #973

Currently, if you try to use a starter kit more than once (for the same 'account') you might run into an issue where by the CLI will report a 409 Conflict when it tries to create a store. This PR fixes that by notifying the user and letting them choose whether they want to link to the existing store or choose a new store to be created (subsequently prompting the user to give a different store name).

You can see in the following screenshot that I use --non-interactive mode, so the CLI will automatically opt for linking to the existing store.

Monosnap testing cli 2023-10-13 10-56-19

@Integralist Integralist force-pushed the integralist/setup-store-multiple-projects branch from b497455 to 2cab334 Compare October 12, 2023 15:23
@Integralist Integralist marked this pull request as ready for review October 12, 2023 15:23
@Integralist Integralist requested a review from fgsch October 12, 2023 15:23
@Integralist Integralist added the enhancement New feature or request label Oct 12, 2023
@Integralist Integralist force-pushed the integralist/setup-store-multiple-projects branch from c662e11 to c10a50d Compare October 13, 2023 10:26
@Integralist Integralist force-pushed the integralist/setup-store-multiple-projects branch from ed5c903 to 8f6eccb Compare October 16, 2023 08:43
Copy link
Contributor

@grantstephens grantstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments, otherwise LGTM

pkg/commands/compute/init.go Outdated Show resolved Hide resolved
pkg/commands/compute/setup/config_store.go Show resolved Hide resolved
pkg/commands/compute/setup/config_store.go Show resolved Hide resolved
pkg/commands/compute/setup/kv_store.go Outdated Show resolved Hide resolved
@Integralist Integralist removed the request for review from awilliams-fastly October 16, 2023 09:26
@Integralist Integralist force-pushed the integralist/setup-store-multiple-projects branch from 8f6eccb to 53de04b Compare October 16, 2023 17:26
Copy link
Contributor

@grantstephens grantstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small, thing, but happy to defer to your judgement. LGTM

pkg/commands/compute/setup/config_store.go Show resolved Hide resolved
@Integralist Integralist merged commit 0f33513 into main Oct 17, 2023
6 checks passed
@Integralist Integralist deleted the integralist/setup-store-multiple-projects branch October 17, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Allow the canonical object-store named to be decided during setup
2 participants