Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compute/deploy): ignore package comparison error #1053

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(compute/deploy): ignore package comparison error #1053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pkg/commands/compute/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,10 +753,12 @@ func (c *DeployCommand) CompareLocalRemotePackage(serviceID string, version int)
ServiceID: serviceID,
ServiceVersion: version,
})
if err != nil {
return err
}
if filesHash == p.Metadata.FilesHash {
// IMPORTANT: Skip error as some services won't have a package to compare.
// This happens in situations where a user will create the service outside of
// the CLI and then reference the Service ID in their fastly.toml manifest.
// In that scenario the service might just be an empty service and so trying
// to get the package from the service with 404.
if err == nil && filesHash == p.Metadata.FilesHash {
return ErrPackageUnchanged
}
return nil
Expand Down
Loading