Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(compute/serve): replace log.Fatal usage with channel #1081

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

Integralist
Copy link
Collaborator

No description provided.

@Integralist Integralist added the enhancement New feature or request label Nov 7, 2023
@Integralist Integralist force-pushed the integralist/avoid-log-fatal-os-exit branch from 0818651 to 778ef18 Compare November 7, 2023 17:50
Copy link
Collaborator

@awilliams-fastly awilliams-fastly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment as this #1082 (comment).

Otherwise, LGTM

@Integralist
Copy link
Collaborator Author

Thanks @awilliams-fastly I think that makes sense for the other PR but for this one I think there's a wrinkle where we have...

eventHandler := func(modifiedFile string, _ fsnotify.Op) { ... } 

...which can't return an error in its current form and I can't convert it to return an error because it's contained by another function debounced(func() {}) that we don't control and can't convert to handle an error. So it gets harder to reason about at that point.

So I think I'll leave it as is for this PR but for I'll definitely look at doing your suggestion for the other PR.

@Integralist Integralist merged commit c930a4a into main Nov 8, 2023
6 checks passed
@Integralist Integralist deleted the integralist/avoid-log-fatal-os-exit branch November 8, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants