Allow compute init to be reinvoked within an existing package directory #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thommahoney
approved these changes
Jul 8, 2020
Comment on lines
+80
to
+86
| if len(d.Flag.Authors) > 0 { | ||
| return d.Flag.Authors, SourceFlag | ||
| } | ||
|
|
||
| if len(d.File.Authors) > 0 { | ||
| return d.File.Authors, SourceFile | ||
| } |
There was a problem hiding this comment.
Would it make sense to combine them?
There was a problem hiding this comment.
They are subtly different. One returns the Flag value, the other returns the File value.
Co-authored-by: Thom Mahoney <mahoneyt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactors
compute initallowing it to be reinvoked within an existing package directory. This is allows more frictionless user journeys between the UI and CLI, for instance allowing as user to regenerate domain or backend etc.Best reviewed with
?w=1to ignore whitespace changes: https://github.com/fastly/cli/pull/138/files?w=1What
serviceid,name,description,author