Constrain Version Upgrade Suggestion #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
force-pushed
the
integralist/2020_11_03_fix_local_version_check
branch
from
2e89a99 to
862b839
Compare
phamann
approved these changes
Nov 3, 2020
Co-authored-by: Patrick Hamann <patrick@fastly.com>
Co-authored-by: Patrick Hamann <patrick@fastly.com>
Integralist
force-pushed
the
integralist/2020_11_03_fix_local_version_check
branch
from
22796ca to
57728ae
Compare
Integralist
deleted the
integralist/2020_11_03_fix_local_version_check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when developing locally,
./fastly versionwould suggest an upgrade to a pre-release version.Solution: version upgrades should only be for standard semver releases (e.g.
v1.1.1notv.1.1.1-rc-1).Notes: customers should (in theory) only be using an 'official' release and won't expect pre-release.