Migrate to Go-Fastly 2.0.0 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
force-pushed
the
integralist/2020_11_18_go_fastly_2.0.0
branch
2 times, most recently
from
c236e6c to
fe74ffa
Compare
|
@phamann this is ready for you (see DM also). |
phamann
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
👍 LGTM - Thank you so much for this very tedious, but very important upgrade!
My only comments are minor and non-blocking:
- A personal preference, but naming of
optional.WasSetseems weird to me and makes the type less portable for use outside of flag actions.IsValidorHasValuemay have been better choices. - I formatted lots of comments per: https://github.com/golang/go/wiki/CodeReviewComments#comment-sentences. Most of them were inline and thus not an issue, but I prefer the consistency.
- Would be good to change the
commentfields in go-fastly asap so they don't become breaking changes.
phamann
force-pushed
the
integralist/2020_11_18_go_fastly_2.0.0
branch
from
46c375c to
e3869bf
Compare
This was referenced Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: multiple lines of tagged releases for Go-Fastly is making adding new features via our various API clients much harder.
Solution: migrate cli to using Go-Fastly 2.0.0