Switch from third-party dependency to our own mirror #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
force-pushed
the
integralist/20210106_kingpin_mirror
branch
from
aabbf88 to
8ac09d2
Compare
|
@phamann once I get your approval I'll cut a patch release so we're on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the third-party CLI parser dependency (Kingpin) is no longer maintained, nor are we using a stable branch.
Solution: use a mirror of the repo that is within the fastly organisation to mitigate potential risk of code deletion.
Notes: this also enables us the opportunity to integrate the various work-arounds within CLI into fastly/kingpin.