-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Compute@Edge Log Tailing #192
Conversation
@jaredmorrow thanks for opening this PR. Seems to be a couple of failing tests due to a missing method expected on an interface. |
@Integralist go-fastly v3 required :) |
db4bfe0
to
8142feb
Compare
With go-fastly v3, it is now passing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaredmorrow I'm not all the way done yet. Stopped at the tail_test.go
file, and I'll continue on from there will my review shortly (just gotta step away for a bit).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the second half of my review (although I see you've pushed some changes so maybe some of this has become irrelevant).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other final comment, not essential.
- Adds command: fastly logs tail --service-id=<sid>
0aeaa9e
to
8cd635d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll merge once the CI tests have passed.
What does it do?
Adds command: fastly logs tail --service-id=
Output
Because this doesn't run w/o the above mentioned go-fastly, the following is what a log tail session looks like with three requests that just print out a simple message.