Add port prompt for compute init #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
commented
Feb 8, 2021
Comment on lines
+100
to
+101
| c.CmdClause.Flag("domain", "The name of the domain associated to the package").StringVar(&c.domain) | ||
| c.CmdClause.Flag("backend", "A hostname, IPv4, or IPv6 address for the package backend").StringVar(&c.backend) |
There was a problem hiding this comment.
I noticed these flags were assigning values to the wrong variable 🤦🏻 so have fixed in this PR.
Integralist
commented
Feb 8, 2021
Integralist
requested review from
a team and
doramatadora
and removed request for
a team
Integralist
force-pushed
the
integralist/20210208_backend_fqd
branch
from
710a569 to
6669cb5
Compare
doramatadora
approved these changes
Feb 9, 2021
Integralist
added
bug
Integralist
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying a backend as part of the interactive prompt input for the
fastly compute initcommand the default behaviour is to create the backend without TLS (i.e. HTTPS/port 443).This is the prompt currently displayed:
When the Backend is created it's actually assigned port 80 (i.e. HTTP) which the mock backend isn't accessible via.
We should provide a prompt for specifying the port so the user has control over this value.