Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite file.Load error with nil #569

Merged
merged 1 commit into from
May 27, 2022
Merged

Don't overwrite file.Load error with nil #569

merged 1 commit into from
May 27, 2022

Conversation

fgsch
Copy link
Member

@fgsch fgsch commented May 27, 2022

Should fix:

ERROR: there was a problem updating the versioning information for the Fastly CLI (we won't check again until 5m have passed):

%!w(<nil>).

@fgsch fgsch requested a review from Integralist May 27, 2022 13:29
@Integralist Integralist changed the title Don't clob the original error when updating fails Don't overwrite file.Load error with nil May 27, 2022
@Integralist Integralist added the bug Something isn't working label May 27, 2022
@Integralist Integralist merged commit 0df504e into main May 27, 2022
@Integralist Integralist deleted the fgsch/preserve-error branch May 27, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgsch @Integralist