Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Papertrail logging endpoint support #57

Merged
merged 1 commit into from
May 13, 2020
Merged

Adds Papertrail logging endpoint support #57

merged 1 commit into from
May 13, 2020

Conversation

mccurdyc
Copy link
Collaborator

@mccurdyc mccurdyc commented May 7, 2020

Relevant (Referenced) Link(s)

Validation

$ make test

git clone git@github.com:mccurdyc/cli.git /tmp/cli && \
( 
    cd /tmp/cli && \
    git checkout mccurdyc/logging-papertrail && \
    make test && \
    rm -rf /tmp/cli \
)

@mccurdyc mccurdyc requested a review from phamann May 7, 2020 14:43
phamann
phamann approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM other than typo suggestions

pkg/logging/papertrail/create.go Outdated Show resolved Hide resolved
pkg/logging/papertrail/delete.go Outdated Show resolved Hide resolved
pkg/logging/papertrail/describe.go Outdated Show resolved Hide resolved
pkg/logging/papertrail/list.go Outdated Show resolved Hide resolved
pkg/logging/papertrail/update.go Outdated Show resolved Hide resolved
@phamann phamann added the enhancement New feature or request label May 8, 2020
phamann
phamann approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mccurdyc
Copy link
Collaborator Author

Force-pushed rebasing master.

@mccurdyc
Copy link
Collaborator Author

Force-pushed rebasing into a single commit.

@mccurdyc
Add Papertrail endpoint support
bc56a89 
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
@mccurdyc
Copy link
Collaborator Author

Force-pushed a formatting fix and rebased into a single commit.

@mccurdyc mccurdyc merged commit 7b711a2 into fastly:master May 13, 2020
@mccurdyc mccurdyc deleted the mccurdyc/logging-papertrail branch May 13, 2020 18:09
@mccurdyc mccurdyc changed the title logging: adds papertrail endpoint Adds Papertrail logging endpoint support May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccurdyc @phamann