Makefile: when building binary, depend on .go files #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you made a change to a source file and ran `make fastly`, it'd say that fastly was up-to-date because the makefile target did not depend on its input files. Fix that by creating a list of all the Go source files and having the makefile target depend on it.
Integralist
approved these changes
Jun 23, 2022
| @@ -21,7 +21,9 @@ LDFLAGS = -ldflags "\ | |||
| -X 'github.com/fastly/cli/pkg/revision.Environment=${CLI_ENV}' \ | |||
| " | |||
|
|
|||
| fastly: | |||
| GO_FILES = $(shell find cmd pkg -type f -name '*.go') | |||
There was a problem hiding this comment.
Interestingly there are 482 go files in this project 😅
There was a problem hiding this comment.
Yeah, I was a little worried about that but I didn't see a noticeable slowdown in builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you made a change to a source file and ran
make fastly, it'd saythat fastly was up-to-date because the makefile target did not depend on
its input files. Fix that by creating a list of all the Go source files
and having the makefile target depend on it.