-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify fastly crate version during compute build. #67
Conversation
b034c82
to
4f54b8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice! Unfortunately cargo update
is not gonna be sufficient for our needs here 😞
c02afd9
to
58ed8bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I can't really comment on the Go style but the semantics look right to me 😂
2f4dd6c
to
16b328c
Compare
@acfoltzer and I discussed this PR on slack, we realised that prompting a user to add @peterbourgon When/If you have some spare time, I'd appreciate a quick review on this. Danke! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits but I grok it 👍
), | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a request for change, but I'm surprised this level of semantic version "parsing" is required by Verify...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha me too 😆
Co-authored-by: Peter Bourgon <peterbourgon@users.noreply.github.com>
TL;DR
Verifies that the
fastly
crate exists as a dependency and is up-to-date duringfastly compute build
. This allows us to ensure that the package program is compatible with the edge runtime environment at compilation time.