-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release process to not use external config #688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments for the reviewer...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we chatted about this on zoom, the approach we discussed was to list SK repo URLs in a file in the CLI repo, and then pull the title and description of the SKs from the SK repo's fastly.toml file during the CLI build. It seems like the solution here is to bake the title and description data into the CLI repo directly, which duplicates and disconnects it from the SK's canonical data.
My concern is that this creates a maintenance overhead, and an unexpected gotcha if you update the SK and then expect the output from the CLI to change.
These are the repos I think we should offer in the CLI, in this order:
- Rust:
- JavaScript
- AssemblyScript
- Go
Could we use that approach, and store only the URLs here in the CLI - adding the other data when the CLI is built?
4b6dcbb
to
f793998
Compare
7cfa830
to
11a7a4c
Compare
@@ -0,0 +1,45 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@triblondon here's the script for generating the config.
dc2fd1e
to
0a24f3b
Compare
0a24f3b
to
afc7593
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, windows CI failure aside :)
41ff2e8
to
7e37a9d
Compare
403d48e
to
1e9fdff
Compare
1e9fdff
to
84ff62b
Compare
The CLI configuration file was being pulled down from a Fastly endpoint that handled the construction of the config (this was because an internal Fastly service already had access to all the starter kit data that was injected into the config for the CLI to consume).
This caused issues with the CLI release process as the person cutting the release might not have waited for the internal system to have run its daily cron that updated the configuration data.
To avoid this race condition we've moved all this logic inside of the CLI's own CI process.