Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compute/deploy): clean-up new service creation on-error #776

Merged
merged 3 commits into from
Jan 27, 2023
Merged

fix(compute/deploy): clean-up new service creation on-error #776

merged 3 commits into from
Jan 27, 2023

Conversation

Integralist
Copy link
Collaborator

No description provided.

@Integralist Integralist added the bug Something isn't working label Jan 25, 2023
@Integralist Integralist force-pushed the integralist/undo-stack branch from 7ad31bf to 4b30819 Compare January 25, 2023 17:19
fgsch
fgsch approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@fgsch fgsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested but code wise it LGTM 👍

@Integralist Integralist force-pushed the integralist/undo-stack branch from 96d1181 to 1ca874a Compare January 27, 2023 16:19
@Integralist Integralist force-pushed the integralist/undo-stack branch from 1ca874a to b673ce7 Compare January 27, 2023 16:21
@Integralist Integralist merged commit d688afd into main Jan 27, 2023
@Integralist Integralist deleted the integralist/undo-stack branch January 27, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgsch fgsch fgsch approved these changes

@awilliams-fastly awilliams-fastly Awaiting requested review from awilliams-fastly

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integralist @fgsch