Rework objectstore subcommand #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgsch
force-pushed
the
fgsch/rework_commands
branch
from
c2e49cc to
0802b06
Compare
fgsch
force-pushed
the
fgsch/rework_commands
branch
2 times, most recently
from
56fbd73 to
8856b3e
Compare
Follows pattern of other commands.
This follows existing patterns, the API and is needed for upcoming work.
Now that we have object-store-keys, `list' is more natural.
Add `Store' to functions and structs.
fgsch
force-pushed
the
fgsch/rework_commands
branch
from
8856b3e to
b12b3f1
Compare
|
Tests would be updated shortly. |
Rename things accordingly. Requested by @Integralist.
fgsch
force-pushed
the
fgsch/rework_commands
branch
from
9585671 to
06cc805
Compare
|
Tests updated. |
Integralist
reviewed
Feb 6, 2023
Missed in previous commit.
Integralist
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR introduces breaking changes (e.g. the exposed interface is updated) requiring a new major version release.