Add commands for S3 logging endpoints #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phamann
force-pushed
the
phamann/s3-logging
branch
from
7f51ba7 to
79428bd
Compare
peterbourgon
approved these changes
Mar 19, 2020
| @@ -115,7 +115,7 @@ func TestBigQueryList(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestBiogQueryDescribe(t *testing.T) { | |||
| func TestBigQueryDescribe(t *testing.T) { | |||
| c.Input.ServerSideEncryption = fastly.S3ServerSideEncryptionAES | ||
| case string(fastly.S3ServerSideEncryptionKMS): | ||
| c.Input.ServerSideEncryption = fastly.S3ServerSideEncryptionKMS | ||
| } |
There was a problem hiding this comment.
Is the zero value of these fields meaningful when the Input goes to the Fastly API?
There was a problem hiding this comment.
Are you asking due to the lack of a default case? The empty string zero value is correct/valid in the API if no value is passed via user.
phamann
force-pushed
the
phamann/s3-logging
branch
from
79428bd to
7af7437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds CRUD commands for Amazon S3 logging endpoints.