-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fsttest: discard header changes after send #124
Conversation
9aa9278
to
7d8cdd8
Compare
This should correctly ignore headers set too late to make it into the response.
7d8cdd8
to
0e1556c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I have a request for a comment explaining why we return a clone.
fsttest/recorder.go
Outdated
if !r.headersDone { | ||
return r.HeaderMap | ||
} | ||
return r.HeaderMap.Clone() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding a comment here to explain the purpose? I'm not sure it's obvious without additional context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point and I agree. Being part of our test harness, I was initally being more liberal about the lack of comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will update the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Let me know if that works for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could have given better feedback the first time through. Apologies for the back and forth!
c7df4c4
to
44ebfb9
Compare
44ebfb9
to
21c408f
Compare
Updated to address feedback. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This should correctly ignore headers set too late to make it into the response.