fsttest: discard header changes after send #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgsch
force-pushed
the
fgsch/discard-changes-after-sent
branch
2 times, most recently
from
9aa9278
to
7d8cdd8
Compare
This should correctly ignore headers set too late to make it into the response.
fgsch
force-pushed
the
fgsch/discard-changes-after-sent
branch
from
7d8cdd8
to
0e1556c
Compare
cee-dub
approved these changes
Jun 27, 2024
joeshaw
reviewed
Jun 27, 2024
fsttest/recorder.go
Outdated
Comment on lines
32
to
35
| if !r.headersDone { | ||
| return r.HeaderMap | ||
| } | ||
| return r.HeaderMap.Clone() |
There was a problem hiding this comment.
Do you mind adding a comment here to explain the purpose? I'm not sure it's obvious without additional context.
There was a problem hiding this comment.
This is a good point and I agree. Being part of our test harness, I was initally being more liberal about the lack of comment.
There was a problem hiding this comment.
Sure, I will update the PR.
There was a problem hiding this comment.
Done. Let me know if that works for you.
cee-dub
changed the title
cee-dub
reviewed
Jun 28, 2024
fgsch
force-pushed
the
fgsch/discard-changes-after-sent
branch
from
c7df4c4
to
44ebfb9
Compare
fgsch
force-pushed
the
fgsch/discard-changes-after-sent
branch
from
44ebfb9
to
21c408f
Compare
|
Updated to address feedback. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should correctly ignore headers set too late to make it into the response.