Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump tinygo version #134

Merged
merged 3 commits into from
Aug 21, 2024
Merged

bump tinygo version #134

merged 3 commits into from
Aug 21, 2024

Conversation

dgryski
Copy link
Member

@dgryski dgryski commented Aug 20, 2024

No description provided.

Copy link
Collaborator

@cee-dub cee-dub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A couple optional things.

@@ -42,7 +42,7 @@ jobs:
go-version: stable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about using oldstable here to keep from having breakage with new Go releases. Thoughts on bumping it back to that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the assumption is devs will discover breakages on their machines well before CI hits. Ok.

.github/workflows/validate.yml Outdated Show resolved Hide resolved
@cee-dub
Copy link
Collaborator

cee-dub commented Aug 21, 2024

Great!

@dgryski dgryski merged commit d70a99b into main Aug 21, 2024
11 checks passed
@dgryski dgryski deleted the dgryski/tinygo-0.33 branch August 21, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants