Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch configstore to new config store hostcalls #135

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

dgryski
Copy link
Member

@dgryski dgryski commented Aug 28, 2024

No description provided.

Copy link
Collaborator

@cee-dub cee-dub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgryski dgryski force-pushed the dgryski/config-store-hostcalls branch from 850540c to 97e9ce3 Compare September 3, 2024 18:46
The configstore package is moving to the new configstore hostcalls, but we
don't want to surprise users who are still using edgedict, so ensure users keep
using the old hostcalls by splitting the implementations.
@cee-dub cee-dub force-pushed the dgryski/config-store-hostcalls branch from 97e9ce3 to 653c0f9 Compare September 3, 2024 19:25
@cee-dub cee-dub merged commit 59c05b9 into main Sep 3, 2024
11 checks passed
@cee-dub cee-dub deleted the dgryski/config-store-hostcalls branch September 3, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants