Expose the ability to set HTTP and TCP keepalives on dynamic backends. #140
Conversation
Co-authored-by: Ulyssa <git@ulyssa.dev>
Co-authored-by: Ulyssa <git@ulyssa.dev>
fsthttp/backend.go
Outdated
| @@ -311,6 +311,52 @@ func (b *BackendOptions) PoolConnections(poolingOn bool) *BackendOptions { | |||
| return b | |||
| } | |||
|
|
|||
| // HttpKeepaliveTime configures how long to allow HTTP connections to remain | |||
| // idle in a connection pool before it should be considered closed. | |||
| func (b *BackendOptions) HttpKeepaliveTime(time time.Duration) *BackendOptions { | |||
There was a problem hiding this comment.
Do we want HTTP instead of Http ?
There was a problem hiding this comment.
https://pkg.go.dev/net/http#ParseHTTPVersion says yes...?
fsthttp/backend.go
Outdated
|
|
||
| // TcpKeepaliveEnable sets whether or not to use TCP keepalives to try to | ||
| // maintain the connetion to the backend. | ||
| func (b *BackendOptions) TcpKeepaliveEnable(enable bool) *BackendOptions { |
There was a problem hiding this comment.
random hit says yes: https://pkg.go.dev/github.com/m-lab/tcp-info/tcp uses TCP
| } | ||
|
|
||
| func (b *BackendConfigOptions) TCPKeepaliveProbes(count uint32) { | ||
| if count > 0 { |
There was a problem hiding this comment.
Count is a uint32 and so always >= 0. Do we want to handle the 0 case too like with KeepaliveEnable or use 0 to disable this option after previously setting it?
There was a problem hiding this comment.
I have a little bit of hesitation about using 0 to unset (I just don't like special values like that), but yes, that's a possibility. Basically, using 0 here would return this value to being the default for the system. If you wanted to turn probes off, you'd still need to unset KeepaliveEnable.
No description provided.