add secretstore.Plaintext convenience function #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This consolidates opening the store, getting the secret, and decrypting the secret into a single call, making more a more convenient API for getting secrets. Update the integration test and example to use this, since it does all the same stuff as before.
dgryski
reviewed
Sep 25, 2024
| // the given secret store and secret name. | ||
| // | ||
| // This is a convenience function that combines the functionality of | ||
| // [Open], [Store.Get], and [Secret.Plaintext]. |
There was a problem hiding this comment.
Do we want to add a caveat if that if you're obtaining multiple secrets from a store to actually call Open/Get/Plaintext etc instead of calling this repeatedly?
There was a problem hiding this comment.
IMO we can skip it, but I'll add it if you feel strongly about it. There's very little overhead, basically just the open hostcall itself and copying a handle or error back into guest space.
There was a problem hiding this comment.
Also, 🚲 🏠 returns the secret value as a []byte for
dgryski
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates opening the store, getting the secret, and decrypting
the secret into a single call, making more a more convenient API for
getting secrets.
Update the integration test and example to use this, since it does
all the same stuff as before.