Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvstore: document the io.Reader/String() consumption behavior #86

Merged
merged 2 commits into from
Oct 25, 2023
Merged

kvstore: document the io.Reader/String() consumption behavior #86

merged 2 commits into from
Oct 25, 2023

Conversation

joeshaw
Copy link
Member

@joeshaw joeshaw commented Oct 24, 2023

Fixes #40.

@joeshaw joeshaw requested a review from dgryski October 24, 2023 21:29
@joeshaw joeshaw merged commit db2c3e0 into main Oct 25, 2023
9 checks passed
@joeshaw joeshaw deleted the joeshaw/kvstore-document-string branch October 25, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeChampion JakeChampion JakeChampion approved these changes

@dgryski dgryski Awaiting requested review from dgryski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kvstore Entry exposes embedded io.Reader but consumes its contents in String
2 participants
@joeshaw @JakeChampion