Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new device package for device detection #92

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

joeshaw
Copy link
Member

@joeshaw joeshaw commented Nov 16, 2023

Calling device.Lookup() returns a Device struct with accessor
methods to get information on the user agent such as name/brand/model as
well as booleans for common device types.

Based on the API in the Rust SDK and our VCL variables.

@joeshaw
Copy link
Member Author

joeshaw commented Nov 16, 2023

This new API requires JSON decoding, but I've tested it on Go and TinyGo, and the integration tests will ensure it works on our supported configurations.

Copy link
Member

@fgsch fgsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Calling `device.Lookup()` returns a `Device` struct with accessor
methods to get information on the user agent such as name/brand/model as
well as booleans for common device types.
Copy link
Member

@fgsch fgsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still 👍

@joeshaw joeshaw merged commit bc56fc2 into main Nov 16, 2023
10 checks passed
@joeshaw joeshaw deleted the joeshaw/device-detection branch November 16, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants