refactor some request code to make the flow simpler & reduce side effects #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeshaw
force-pushed
the
joeshaw/request-cleanup
branch
from
d4627de
to
1de5487
Compare
|
@joeshaw is this waiting for a review? |
|
@JakeChampion Yes, and so is #44, its related PR. |
JakeChampion
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started doing this to bring #44 up-to-date to decide if we really want to do it. I found the inconsistency on whether to use the struct members confusing, so I removed them. Another approach would be to go the other way and lean into tracking that state on the Request struct.