-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test a few ways to test and clear #21
Open
rjbs
wants to merge
2
commits into
master
Choose a base branch
from
keyword-set-clear
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,119 @@ | ||
use strict; | ||
use warnings; | ||
use Test::Routine; | ||
use Test::Routine::Util; | ||
|
||
with 'JMAP::TestSuite::Tester'; | ||
|
||
use JMAP::TestSuite::Util qw(batch_ok pristine_test); | ||
|
||
use Test::Deep ':v1'; | ||
use Test::Deep::JType; | ||
use Test::More; | ||
use JSON qw(decode_json); | ||
use JSON::Typist; | ||
use Test::Abortable; | ||
use Path::Tiny; | ||
use Digest::MD5 qw(md5_hex); | ||
|
||
use utf8; | ||
|
||
test "update email keywords" => sub { | ||
my ($self) = @_; | ||
|
||
my $tester = $self->tester; | ||
|
||
my $mbox = $self->context->create_mailbox; | ||
|
||
my $from = "test$$\@example.net"; | ||
my $to = "recip$$\@example.net"; | ||
my $subject = "A subject for $$"; | ||
|
||
my @setters = ( | ||
{ | ||
desc => "bulk set", | ||
data => { keywords => { '$Flagged' => jtrue } }, | ||
}, | ||
{ | ||
desc => "patch set", | ||
data => { 'keywords/$Flagged' => jtrue }, | ||
}, | ||
{ | ||
desc => "patch set integer", | ||
data => { 'keywords/$Flagged' => 1 }, | ||
fail => 1, | ||
}, | ||
); | ||
|
||
my @clearers = ( | ||
{ | ||
desc => "bulk clear", | ||
data => { keywords => { } }, | ||
}, | ||
{ | ||
desc => "patch set null", | ||
data => { 'keywords/$Flagged' => undef }, | ||
}, | ||
{ | ||
desc => "patch set false", | ||
data => { 'keywords/$Flagged' => jfalse }, | ||
set_fail => 1, | ||
}, | ||
); | ||
|
||
SETTER: for my $setter (@setters) { | ||
GETTER: for my $clearer (@clearers) { | ||
subtest "setter($setter->{desc}) clearer($clearer->{desc})" => sub { | ||
my $message = $mbox->add_message({ | ||
from => $from, | ||
to => $to, | ||
subject => $subject, | ||
}); | ||
|
||
$tester->request_ok( | ||
[ "Email/get" => { ids => [ $message->id ] } ], | ||
superhashof({ list => [ superhashof({ keywords => {} }) ] }), | ||
"newly created email has no keywords", | ||
); | ||
|
||
$tester->request_ok( | ||
[ "Email/set" => { update => { $message->id => $setter->{data} } } ], | ||
($setter->{fail} | ||
? superhashof({ notUpdated => { $message->id => ignore } }) | ||
: superhashof({ updated => { $message->id => ignore } })), | ||
'tried to set $flagged keyword: should ' . ($setter->{fail} ? 'fail' : 'work') | ||
); | ||
|
||
return if $setter->{fail}; | ||
|
||
$tester->request_ok( | ||
[ "Email/get" => { ids => [ $message->id ] } ], | ||
superhashof({ list => [ superhashof({ keywords => { '$flagged' => jtrue() } }) ] }), | ||
'...and it worked, keyword $flagged set', | ||
); | ||
|
||
$tester->request_ok( | ||
[ "Email/set" => { update => { $message->id => $clearer->{data} } } ], | ||
($clearer->{fail} | ||
? superhashof({ notUpdated => { $message->id => ignore } }) | ||
: superhashof({ updated => { $message->id => ignore } })), | ||
'tried to clear $flagged keyword: should ' . ($clearer->{fail} ? 'fail' : 'work') | ||
); | ||
|
||
return if $clearer->{fail}; | ||
|
||
$tester->request_ok( | ||
[ "Email/get" => { ids => [ $message->id ] } ], | ||
superhashof({ list => [ superhashof({ keywords => { } }) ] }), | ||
"...and it worked, keyword removed", | ||
); | ||
}; | ||
|
||
next SETTER if $setter->{fail}; | ||
} | ||
} | ||
}; | ||
|
||
run_me; | ||
done_testing; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GETTER -> CLEARER would be clearer