Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax highlighting to readme examples #41

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Add syntax highlighting to readme examples #41

merged 2 commits into from
Oct 24, 2019

Conversation

ivy
Copy link
Contributor

@ivy ivy commented Oct 24, 2019

Cool gem! I especially appreciate your effort to implement an abstraction around the various API resources.

This pull request adds some syntax highlighting to the code examples and adds a short doc comment to Harvesting::Enumerable.

It wasn't immediately apparent to me what this module was doing without
reading the code more closely.
Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivy Looks great, thanks! 💯

@etagwerker etagwerker merged commit 1e130e7 into fastruby:master Oct 24, 2019
@ivy ivy deleted the readme-tweaks branch October 24, 2019 05:37
@ivy
Copy link
Contributor Author

ivy commented Oct 24, 2019

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants