Relax http dependency #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etagwerker
approved these changes
Dec 7, 2020
There was a problem hiding this comment.
@julianrubisch I'm all for relaxing this dependency, but this will generate a warning when building the gem:
WARNING: open-ended dependency on http (>= 3.3) is not recommended
if http is semantically versioned, use:
add_runtime_dependency 'http', '~> 3.3'
I don't think it is a big deal. Thoughts, @mscottford or @bronzdoc?
|
Hmm is there another way to allow http 4? |
|
How about |
etagwerker
approved these changes
Dec 11, 2020
|
@julianrubisch Just released this fix in v0.5.1: https://rubygems.org/gems/harvesting/versions/0.5.1 -- Thanks! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this to work with another gem in my depdency tree.
Tests look okay for me, please let me know if I can do anything!