Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Lead Promotion Logic to Improve Separation of Concerns #1398

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

fixing whitespace issue in leads_helper.rb end of file

2857cc9
Select commit
Loading
Failed to load commit list.
Open

Refactor Lead Promotion Logic to Improve Separation of Concerns #1398

fixing whitespace issue in leads_helper.rb end of file
2857cc9
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / RuboCop succeeded Dec 11, 2024 in 7s

10 new alerts

New alerts in code changed by this pull request

  • 10 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 119 in app/controllers/entities/leads_controller.rb

See this annotation in the file changed.

Code scanning / Rubocop

Keep indentation straight. Note

Layout/IndentationConsistency: Inconsistent indentation detected.

Check notice on line 119 in app/controllers/entities/leads_controller.rb

See this annotation in the file changed.

Code scanning / Rubocop

Use 2 spaces for indentation. Note

Layout/IndentationWidth: Use 2 (not 0) spaces for indentation.

Check notice on line 120 in app/controllers/entities/leads_controller.rb

See this annotation in the file changed.

Code scanning / Rubocop

Use 2 spaces for indentation. Note

Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.

Check notice on line 274 in app/controllers/entities/leads_controller.rb

See this annotation in the file changed.

Code scanning / Rubocop

Checks trailing blank lines and final newline. Note

Layout/TrailingEmptyLines: Final newline missing.

Check notice on line 11 in app/helpers/lead_promotion_helper.rb

See this annotation in the file changed.

Code scanning / Rubocop

Avoid trailing whitespace. Note

Layout/TrailingWhitespace: Trailing whitespace detected.

Check notice on line 12 in app/helpers/lead_promotion_helper.rb

See this annotation in the file changed.

Code scanning / Rubocop

Use 2 spaces for indentation. Note

Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.

Check notice on line 15 in app/helpers/lead_promotion_helper.rb

See this annotation in the file changed.

Code scanning / Rubocop

Avoid trailing whitespace. Note

Layout/TrailingWhitespace: Trailing whitespace detected.

Check notice on line 19 in app/helpers/lead_promotion_helper.rb

See this annotation in the file changed.

Code scanning / Rubocop

Avoid trailing whitespace. Note

Layout/TrailingWhitespace: Trailing whitespace detected.

Check notice on line 23 in app/helpers/lead_promotion_helper.rb

See this annotation in the file changed.

Code scanning / Rubocop

Avoid trailing whitespace. Note

Layout/TrailingWhitespace: Trailing whitespace detected.

Check notice on line 173 in app/models/entities/lead.rb

See this annotation in the file changed.

Code scanning / Rubocop

Checks trailing blank lines and final newline. Note

Layout/TrailingEmptyLines: Final newline missing.