-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make reduce_to_pole
work for arbitrary dimension names
#509
Make reduce_to_pole
work for arbitrary dimension names
#509
Conversation
…ate names aren't northing, easting
@zaarcvon thank you for the fix! Would you mind adding a quick test in that runs the reduction to the pole with a grid with dims that have another name? It could be a modification of this test https://github.com/fatiando/harmonica/blob/main/harmonica/tests/test_transformations.py#L615 that renames the dims of the test grid before doing RTP. Would be worth checking that the test fails with the code in |
Hi, @leouieda! I included a test function. I hope everything is done correctly. This is my first experience working with pytest |
d0c713c
to
8978bbf
Compare
Hi, @leouieda . I see that some checks are failing. I understand one related to style and will fix it, but it's not clear what the code style/format check is really about. |
Hi @zaarcvon. The two check that are failing are due to code style. The format one is easy to solve, we just need to run black on the project. You can do it by running |
Hi @zaarcvon! Today @YagoMCastro fixed the code style issues in your PR, so now we are ready to merge this. Thanks a lot for the contribution! 🚀 |
reduce_to_pole
work for arbitrary dimension names
Fix bug in
reduction_to_pole
that made it to work only if the dimensions of the passed grid werenorthing
andeasting
. Now the grid can have arbitrary dimension names. Add tests for these changes.Relevant issues/PRs:
Fixes #439 bug issue: the reduction_to_pole filter produces an error when grid coordinate names are not "northing" and "easting".
Now, it works regardless of grid coordinate names.