Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for load_registry_from_doi when the doi has a slash in the filename #341

Closed
santisoler opened this issue Feb 14, 2023 · 0 comments · Fixed by #340
Closed

Add test for load_registry_from_doi when the doi has a slash in the filename #341

santisoler opened this issue Feb 14, 2023 · 0 comments · Fixed by #340
Labels
enhancement Idea or request for a new feature maintenance A maintenance task to improve development

Comments

@santisoler
Copy link
Member

Description of the desired feature:

We should add a test function that checks if the load_registry_from_doi method introduced in #325 will work with the bugfix introduced in #337. Probably would be better to create a utils function that returns the url to the special Zenodo repo that contains a slash in the filename and reuse it among the test functions.

This could be solve in #337 once #325 is merged. Otherwise, it's ok to leave it for its own PR.

Are you willing to help implement and maintain this feature? For sure!

@santisoler santisoler added enhancement Idea or request for a new feature maintenance A maintenance task to improve development labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Idea or request for a new feature maintenance A maintenance task to improve development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant