Support Zenodo urls with slashes in the filename #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try another way of supporting Zenodo urls that have slashes in the filename.
Test the parse_url and the DOIDownloader against a Zenodo url that contains a slash in the path.
4 tasks
|
@djmannion, can you confirm that this other patch works locally for you? I think this a much better solution that the one before. |
|
Yes, confirming that this version fixes my issue - and not having to specifically handle the extra slash is great from a user perspective, thanks! |
This allows to reuse this function in future tests, instead of having to hardcode the doi multiple times. Simplify the process in case we need to update that Zenodo repository and get a new doi.
Add a new test function that checks if populating the registry with the `load_registry_from_doi` method works as expected when the repo is a Zenodo one with slashes in the filename.
|
Nice to hear that @djmannion. I'm merging this. I'm planning to make a Pooch release before the end of the month, so this bugfix will be available very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
DOIDownloaderto work with files uploaded to Zenodo that have a forward slash "/" in their name. These special cases are generated by the Zenodo-GitHub integration service, where the first portion of the filename matches the GitHub handle of the repository owned and the last portion matches the repository name. Now theparse_urlfunction handles Zenodo dois under a special case: the netloc will be formed with the first two "parts" (prefix/suffix), while the path will be formed by everything that follows the second slash.Relevant issues/PRs:
Fixes #336, fixes #341 and outperforms the idea drafted in #337