Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable updates #291

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Conversation

dopplershift
Copy link
Contributor

@dopplershift dopplershift commented Jan 18, 2022

This gives users the option, when creating a Pooch, to disallow updating local copies of files. The intended use case for this is for development checkouts/CI systems where the local copies are canonical and any need to update likely reflects a problem with the registry (like and out of date hash).

Fixes #290.

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

@welcome
Copy link

welcome bot commented Jan 18, 2022

💖 Thank you for opening your first pull request in this repository! 💖

A few things to keep in mind:

No matter what, we are really grateful that you put in the effort to do this!

@dopplershift dopplershift force-pushed the allow-updates branch 2 times, most recently from 58c8707 to c117dcd Compare January 18, 2022 23:57
This gives users the option, when creating a Pooch, to disallow updating
local copies of files. The intended use case for this is for development
checkouts/CI systems where the local copies are canonical and any need
to update likely reflects a problem with the registry (like and out of
date hash).
Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 looks great @dopplershift! Merging this in. I'll make a new release as soon as I can.

@leouieda leouieda merged commit dd7f890 into fatiando:main Jan 21, 2022
@welcome
Copy link

welcome bot commented Jan 21, 2022

🎉 Congrats on merging your first pull request and welcome to the team! 🎉

If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file of this repository. Feel free to do this in a new pull request if needed.

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@dopplershift dopplershift deleted the allow-updates branch January 21, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local-only/strict mode
2 participants