Fix bug: Figshare downloaders fetch correct version #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug that made Figshare downloaders to fetch always the latest version. Now the `api_response` property parses the DOI to get the desired version of the repository and makes use of the Figshare API to get the list of files available for that particular version. If no version is specified through the DOI, the last version will be fetched, keeping backward compatibility and the default behaviour of Zenodo. Add test functions.
|
@leouieda I went through this PR a couple of times and I think it's ready. It solves the bug, doesn't break any backward compatibility (in fact it keeps the old behaviour of letting figshare to return the latest version if no version is specified), it adds a test for this bug and the code is tidy. I'm merging this so we can work on the next release of Pooch. If any change should be made, we can always release a patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug that made Figshare downloaders to fetch always the latest version. Now the
api_responseproperty ofFigshareRepositoryparses the DOI to get the desired version of the repository and makes use of the Figshare API to get the list of available files for that particular version. If no version is specified through the DOI, the last version will be fetched, keeping backward compatibility and the default behaviour of Zenodo. Add test functions.Relevant issues/PRs:
Fixes #342